Hi Andrey, On 12/14/2017 11:52 AM, Andrey Smirnov wrote: > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: Jason Wang <jasow...@redhat.com> > Cc: Philippe Mathieu-Daudé <f4...@amsat.org> > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org > Cc: yurov...@gmail.com > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com>
I have a more complete patch coming implementing the CTRL2_VOLTAGE_SWITCH (LSB part of the ACMD12ERRSTS register) but in the meaning time your patch is fine. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/sd/sdhci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > index 758af067f9..cb9e0db9fb 100644 > --- a/hw/sd/sdhci.c > +++ b/hw/sd/sdhci.c > @@ -1139,6 +1139,9 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val, > unsigned size) > s->admasysaddr = (s->admasysaddr & (0x00000000FFFFFFFFULL | > ((uint64_t)mask << 32))) | ((uint64_t)value << 32); > break; > + case SDHC_ACMD12ERRSTS: > + MASKED_WRITE(s->acmd12errsts, mask, value); > + break; > case SDHC_FEAER: > s->acmd12errsts |= value; > s->errintsts |= (value >> 16) & s->errintstsen; >