> This is rewritten later, why bother setting this here? > >> >> >> - dma_memory_read(&address_space_memory, entry_addr + 2, >> - (uint8_t *)(&dscr->length), 2); >> - dscr->length = le16_to_cpu(dscr->length); >> + dscr->length = lduw_le_dma(&address_space_memory, entry_addr + 2); >> >> >> - dma_memory_read(&address_space_memory, entry_addr + 4, >> - (uint8_t *)(&dscr->addr), 8); > > What about dscr->addr which is set here?
Oops. I'll drop this patch. >> - dscr->attr = le64_to_cpu(dscr->attr); >> + dscr->attr = ldq_le_dma(&address_space_memory, entry_addr + 4); >> >> The API is detailled in this file: docs/devel/loads-stores.rst
