On 14/12/2017 10:06, Kevin Wolf wrote: > Am 14.12.2017 um 00:20 hat Philippe Mathieu-Daudé geschrieben: >> Use Base64 to serialize the binary blobs in JSON. >> So far at most 512 bytes will be transfered, which result >> in a 684 bytes payload. >> Since this command is intented for qtesting, this is acceptable. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > Doing this kind of thing over QMP doesn't look right to me. qtests > should access hardware the same way as real guests access the hardware > (i.e. MMIO and I/O ports). > > But if for some reason the QMP maintainers were to think that this is > acceptable in QMP, I'd argue it should at least get an x-debug- prefix > to avoid making it a stable API that management tools may rely on.
Yeah, what we usually do is not test the device (e.g. SCSI) directly, but only through the HBA (e.g. virtio-scsi or AHCI, it would be SDHCI in this case). Thanks, Paolo
