On Tue, Dec 21, 2010 at 5:20 AM, Harsh Prateek Bora <ha...@linux.vnet.ibm.com> wrote: > This patch removes the addition of null char in symlink file > which is being appended to file in case of mapped security model. > Without this patch, the extra null char causes LTP testcase lstat03 > to fail and hence this fix is required.
Looks good. Related note: local_readlink() with fs_sm == SM_MAPPED reads the contents of *any* file. I don't see a check that the file is actually a symlink. What if an application relies on the EINVAL return value when calling readlink() on something that is not a file (not sure how this maps through to 9p though)? Stefan
