On 12/04/2017 12:15 PM, Cornelia Huck wrote:
> On Fri, 1 Dec 2017 15:31:35 +0100
> Halil Pasic <pa...@linux.vnet.ibm.com> wrote:
>
>> Let us advertise the changes introduced by "s390x/css: unrestrict cssids"
>> to the management software (so it can tell are cssids unrestricted or
>> restricted).
>>
>> Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com>
>> ---
>>
>> Boris says having the property on the virtual-css-bridge is good form
>> Libvirt PoV. @Shalini: could you verify that things work out fine
>> (provided we get at least a preliminary blessing from Connie).
>>
>> Consider squashing into "s390x/css: unrestrict cssids".
>> ---
>> hw/s390x/css-bridge.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c
>> index c4a9735d71..c7e8998680 100644
>> --- a/hw/s390x/css-bridge.c
>> +++ b/hw/s390x/css-bridge.c
>> @@ -123,6 +123,11 @@ static Property virtual_css_bridge_properties[] = {
>> DEFINE_PROP_END_OF_LIST(),
>> };
>>
>> +static bool prop_get_true(Object *obj, Error **errp)
>> +{
>> + return true;
>> +}
>> +
>> static void virtual_css_bridge_class_init(ObjectClass *klass, void *data)
>> {
>> HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);
>> @@ -131,6 +136,12 @@ static void virtual_css_bridge_class_init(ObjectClass
>> *klass, void *data)
>> hc->unplug = ccw_device_unplug;
>> set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>> dc->props = virtual_css_bridge_properties;
>> + object_class_property_add_bool(klass, "cssid-unrestricted",
>> + prop_get_true, NULL, NULL);
>> + object_class_property_set_description(klass, "cssid-unrestricted",
>> + "A css device can use any cssid, regardless whether virtual"
>
> extra space -----------------------------^
>
Nod.
>> + " or not (read only, always true)",
Do we need "." here ----------------------------^ ?
>> + NULL);
>> }
>>
>> static const TypeInfo virtual_css_bridge_info = {
>
> Looks reasonable. If this works as expected, I'll squash it into the
> previous patch.
>
I've just asked Shalini to verify the libvirt perspective.
Supposed we verify this works as expected, I read I don't have to spin
a v2 and you are going to fix the issues found yourself. Right?
