On Thu, Nov 30, 2017 at 05:21:48PM +0000, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Introducing new return path message MIG_RP_MSG_RECV_BITMAP to send > > received bitmap of ramblock back to source. > > > > This is the reply message of MIG_CMD_RECV_BITMAP, it contains not only > > the header (including the ramblock name), and it was appended with the > > whole ramblock received bitmap on the destination side. > > > > When the source receives such a reply message (MIG_RP_MSG_RECV_BITMAP), > > it parses it, convert it to the dirty bitmap by inverting the bits. > > > > One thing to mention is that, when we send the recv bitmap, we are doing > > these things in extra: > > > > - converting the bitmap to little endian, to support when hosts are > > using different endianess on src/dst. > > > > - do proper alignment for 8 bytes, to support when hosts are using > > different word size (32/64 bits) on src/dst. > > > > Signed-off-by: Peter Xu <pet...@redhat.com> > > (The comment on the receive side 'Add addings' is a bit odd! > The send side is much better); other than that: > > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Ouch. It was meant to be "Add paddings". :) I'll keep the r-b, though, with the fix. Thanks, > > + /* Add addings */ > > + le_bitmap = bitmap_new(nbits + BITS_PER_LONG); -- Peter Xu
