On Wed, Nov 29, 2017 at 07:46:25PM +1100, David Gibson wrote:
[...]
> struct PCIBus {
> BusState qbus;
> + enum PCIBusFlags flags;
> PCIIOMMUFunc iommu_fn;
> void *iommu_opaque;
> uint8_t devfn_min;
> @@ -440,8 +446,12 @@ struct PCIBus {
> Notifier machine_done;
> };
I would prefer directly defining flags as uint64_t then it's more
clear that it's a bitmask (enum let me think of only one flag will be
set, but I may be wrong), but it's fine too to me.
Reviewed-by: Peter Xu <pet...@redhat.com>
--
Peter Xu
