On 29.11.2017 19:10, Richard Henderson wrote:
> On 11/28/2017 08:33 PM, David Hildenbrand wrote:
>> qemu_mutex_lock_iothread();
>> int r = sclp_service_call(env, r1, r2);
>> if (r < 0) {
>> - program_interrupt(env, -r, 4);
>> - r = 0;
>> + program_interrupt_ra(env, -r, 4, GETPC());
>> }
>> qemu_mutex_unlock_iothread();
>> return r;
>
> Incidentally, shouldn't the unlock happen before throwing the exception?
> We will unlock after a longjmp, but it does look odd to write it this way.
>
Yes, but we have that all over the place, no? The unlock here could be
moved up.
>
> r~
>
--
Thanks,
David / dhildenb
