Hello Peter,
Am 17.12.2010 um 16:56 schrieb Peter Maydell:
The softfloat functions float*_is_nan() were badly misnamed,
because they return true only for quiet NaNs, not for all NaNs.
Rename them to float*_is_quiet_nan() to more accurately reflect
what they do.
This change was produced by:
perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan)
(with the results manually checked.)
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Nathan Froyd <froy...@codesourcery.com>
Acked-by: Edgar E. Iglesias <edgar.igles...@gmail.com>
---
This is just a refresh of the first patch against current master;
the only difference is that the addition of
float32_maybe_silence_nan()
meant that the context for the hunk in softfloat.h changing the
prototypes is slightly different. I've therefore retained the
reviewed-by/acked-by lines from the first time around.
Can this patch be applied? (There are more ARM/softfloat patches
in my queue which will break it again otherwise...)
If we're engaging into refactoring the softfloat library, I still have
a large'ish patch lying around to fix signature mismatches between
header and sources wrt to integer arguments and migrating to POSIX
integer types (BeOS/Haiku system headers define int32 etc.
differently). Browsing through your patch it shouldn't conflict, but I
guess it'll be best to have it go through your queue to avoid troubles.
Regards,
Andreas
