On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > nbd/server.c | 74 > +++++++++++++++++++++++++++++++++++++----------------------- > 1 file changed, 46 insertions(+), 28 deletions(-) >
> @@ -418,8 +447,8 @@ static int nbd_negotiate_handle_info(NBDClient *client,
> uint16_t myflags,
> be16_to_cpus(&requests);
> trace_nbd_negotiate_handle_info_requests(requests);
> if (requests != client->optlen / sizeof(request)) {
> - msg = "incorrect number of requests for overall length";
> - goto invalid;
> + return nbd_opt_invalid(
> + client, errp, "incorrect number of requests for overall length");
Nice that you are fixing the typo of the double space in the error message.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
