On 2017-11-21 23:16, John Snow wrote:
> Commit 2b7731938d9 adds a blkdebug driver test for failing commits, but
> the vmdk driver doesn't appear to appreciate this format:
>
> +_qemu_img_wrapper create -f vmdk -b "json:{'driver': 'raw',
> + 'file': {
> + 'driver': 'blkdebug',
> + 'inject-error': [{
> + 'event': 'write_aio',
> + 'errno': 28,
> + 'once': true
> + }],
> + 'image': {
> + 'driver': 'null-co'
> + }}}"
> "/home/bos/jhuston/src/qemu/bin/git/tests/qemu-iotests/scratch/t.vmdk"
> +qemu-img: TEST_DIR/t.IMGFMT: Could not create image: Invalid argument
>
>
> ...so;
>
> (A) VMDK should be dropped from 020, or
> (B) This sub-test should be rewritten, or
> (C) This sub-test should be split out into a new unit where VMDK can be
> dropped.
>
> I don't like (A) very much because I like testing our weird formats when
> possible, I don't like (B) very much because I don't really like
> wrangling QMP commands inside of the bash unit tests.
>
> (C) Could work; though it's odd to have it away from its kin in 020.The issue is not blkdebug, the issue is that the backing file is not in vmdk format (because it's a null-co node at heart). I can make it a VMDK, but that'll be fun either when specifying the backing file file.image node because this test is supposed to work with all protocols but NFS; or I'll have to resort to the gold old blkdebug:conf:file syntax... But why not, it works. Now I'll just have to figure this out: -qemu-img: Block job failed: No space left on device +Image committed. :-/ Max
signature.asc
Description: OpenPGP digital signature
