On 6 November 2017 at 15:47, Andrey Smirnov <andrew.smir...@gmail.com> wrote: > Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset > 0x614, so to avoid getting aborts when accessing those on QEMU, extend > the register file to cover 4KB of address space instead of just 1K. > > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: Jason Wang <jasow...@redhat.com> > Cc: Philippe Mathieu-Daudé <f4...@amsat.org> > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org > Cc: yurov...@gmail.com > Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com> > --- > hw/net/imx_fec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c > index 48d012cad6..e236bc933c 100644 > --- a/hw/net/imx_fec.c > +++ b/hw/net/imx_fec.c > @@ -1252,7 +1252,7 @@ static void imx_eth_realize(DeviceState *dev, Error > **errp) > SysBusDevice *sbd = SYS_BUS_DEVICE(dev); > > memory_region_init_io(&s->iomem, OBJECT(dev), &imx_eth_ops, s, > - TYPE_IMX_FEC, 0x400); > + TYPE_IMX_FEC, 0x1000); > sysbus_init_mmio(sbd, &s->iomem); > sysbus_init_irq(sbd, &s->irq[0]); > sysbus_init_irq(sbd, &s->irq[1]); > --
I notice that we have an unused #define FSL_IMX25_FEC_SIZE 0x4000 in fsl-imx25.h, and the Linux device trees for the imx25 define the size of the FEC register block as 0x4000. Should this be 0x4000 ? thanks -- PMM
