On 11/17/2017 04:59 PM, John Snow wrote: >>> So for this test, the easiest solution is to filter out the >>> actual hash value. Broken in commit 4096974e. >> >> Of course, if Kevin sends a v2 pull, it's probably better to just squash >> this in to my original testsuite change (since a v2 would probably >> invalidate that commit id). >> > > Whichever way you go,
Commit 4096974e has already landed in master, so this commit message is correct as-is and belongs in the next pull request (whether for -rc2 or -rc3 depends on timing). > > Reviewed-by: John Snow <js...@redhat.com> > > I don't know how important it is to nail this down, but the purpose of > this command is primarily for sanity testing and not necessarily between > architectures, so this might just be a limitation to document. > > Also, don't use this for anything except testing. Indeed, the name of x-debug-block-dirty-bitmap-sha256 already implies its limited portability; but it also gives us free reign to change it's behavior if we find something we like better for the same ease of bitmap testing/debugging. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
