On 11/16/2017 06:13 PM, Darren Kenny wrote:
On Thu, Nov 16, 2017 at 10:28:32AM +0800, Mao Zhongyi wrote:
Cc: Peter Maydell <peter.mayd...@linaro.org>
Cc: Jason Wang <jasow...@redhat.com>
Cc: Zhang Chen <zhangc...@gmail.com>
Cc: Li Zhijian <lizhij...@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonz...@redhat.com>
Fixes: 8ec14402029d783720f4312ed8a925548e1dad61
Reported-by: Peter Maydell <peter.mayd...@linaro.org>
Reported-by: Paolo Bonzini <pbonz...@redhat.com>
Signed-off-by: Mao Zhongyi <maozy.f...@cn.fujitsu.com>
Code-wise, this looks like a valid fix to the existing code.
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
Hi, Darren
But testing wise, have you confirmed that things are behaving as you
expected with the previous patch, since previously when calling
colo_compare_connection(), the value of conn would have always been
its initialized value of NULL.
Well, in my test machine the code like *con = conn, but when I made
the patch on another machine I wrote the code con = &conn carelessly.
Just want to be sure that fixing this doesn't end up breaking your
expected behaviour given that all your testing before would have had
a NULL value in conn.
Thanks for the kind reminder.
Thanks,
Mao
Thanks,
Darren.
---
net/colo-compare.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index ccdcba2..1ce195f 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -179,7 +179,7 @@ static int packet_enqueue(CompareState *s, int mode,
Connection **con)
"drop packet");
}
}
- con = &conn;
+ *con = conn;
return 0;
}
--
2.9.4
