Peter Maydell <peter.mayd...@linaro.org> writes: > On 20 October 2017 at 20:08, Stefan Weil <s...@weilnetz.de> wrote: >> Am 20.10.2017 um 20:24 schrieb alind...@codeaurora.org: >>> On 2017-10-20 05:27, Peter Maydell wrote: >>>> Do we even need this code at all? As far as I can tell from >>>> the git logs, the idea is to support users who hand-modify >>>> config-devices.mak. But do we want to support that? I would >>>> think of config-devices.mak as an internal part of the build >>>> machinery, and the bit you can edit as a user is the stuff >>>> in default-configs/. >> >> It's a long time since I wrote that code, but when I look at >> the commit message for my commit 012f0879234, it was written >> for users who do _not_ hand-modify config-devices.mak. They >> had a problem when they updated the code from git and the >> new version had changed some of the device configurations >> which were used to build config-devices.mak. > > Right, but it's only this complicated set of conditions > because we seem to be also trying to support the hand-modify > case. Otherwise we could just generate the new version > and copy it into place if it's changed, unconditionally...
So, do we need this patch? If yes, who's going to merge it? If no, do we need some other patch?
