On 03.11.2017 11:13, Daniel P. Berrange wrote: > On Fri, Nov 03, 2017 at 10:39:13AM +0100, Thomas Huth wrote: >> The test-crypto-block currently fails if encryption has not been >> compiled into QEMU [...] >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index 434a2ce..ac46aea 100644 >> --- a/tests/Makefile.include >> +++ b/tests/Makefile.include >> @@ -145,7 +145,7 @@ check-unit-$(if >> $(CONFIG_NETTLE_KDF),y,$(CONFIG_GCRYPT_KDF)) += tests/test-crypt >> check-unit-y += tests/test-crypto-ivgen$(EXESUF) >> check-unit-y += tests/test-crypto-afsplit$(EXESUF) >> check-unit-y += tests/test-crypto-xts$(EXESUF) >> -check-unit-y += tests/test-crypto-block$(EXESUF) >> +check-unit-$(call lor,$(CONFIG_NETTLE_KDF),$(CONFIG_GCRYPT_KDF)) += >> tests/test-crypto-block$(EXESUF) > > This is disabling the entire test suite, even though only the LUKS part of > the test suite has problems. Can you just extend the logic for setting the > TEST_LUKS condition in the test source code instad.
Ah, ok, that sounds of course like the better solution, I'll have a try... Thomas
