On 10/20/2017 09:41 AM, Mark Cave-Ayland wrote: >>> - dev = qdev_create(NULL, "sparc32-dma-device"); >>> + dev = qdev_create(NULL, is_ledma ? "sparc32-ledma" : "sparc32-espdma"); >> >> TYPE_SPARC32_LEDMA_DEVICE and TYPE_SPARC32_ESPDMA_DEVICE? > > Again please note that this patch is an intermediate step and the type > is switched over to use the macro later in the patchset when the type > macro is eventually moved over to sparc32_dma.h.
Oops sorry! I missed this mail while reviewing your v4.