On 27/10/17 00:33, Philippe Mathieu-Daudé wrote: > On 10/26/2017 10:04 AM, Daniel P. Berrange wrote: >> Some people building QEMU use VPATH builds where the source directory is on a >> read-only volume. In such a case 'scripts/git-submodules.sh update' will >> always >> fail and users are required to run it manually themselves on their original >> writable source directory. >> >> While this is already supported, it is nice to give users a command line flag >> to configure to permanently disable automatic submodule updates, as it means >> they won't get hard to diagnose failures from git-submodules.sh at an >> arbitrary >> later date. >> >> This patch thus introduces a flag '--disable-git-update' which will prevent >> 'make' from ever running 'scripts/git-submodules.sh update'. It will still >> run >> the 'status' command to determine if a submodule update is needed, but when >> it >> does this it'll simply stop and print a message instructing the developer >> what >> todo. eg >> >> $ ./configure --target-list=x86_64-softmmu --disable-git-update >> ...snip... >> >> $ make >> GEN config-host.h >> GEN trace/generated-tcg-tracers.h >> GEN trace/generated-helpers-wrappers.h >> GEN trace/generated-helpers.h >> GEN trace/generated-helpers.c >> GEN module_block.h >> >> GIT submodule checkout is out of date. Please run >> scripts/git-submodule.sh update ui/keycodemapdb >> from the source directory checkout /home/berrange/src/virt/qemu > > Clean :) > >> >> make: *** [Makefile:31: git-submodule-update] Error 1 >> >> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
What tree did you apply on top of? Does not apply for me :-/ -- Alexey
