Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171024230758.31779-1-rig...@google.com
Subject: [Qemu-devel] [PATCH] linux-user: fix is_proc_myself to check the paths
via realpath
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/1508898544-10307-1-git-send-email-sundeep.l...@gmail.com ->
patchew/1508898544-10307-1-git-send-email-sundeep.l...@gmail.com
Switched to a new branch 'test'
a09fb58573 linux-user: fix is_proc_myself to check the paths via realpath
=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user: fix is_proc_myself to check the paths via
realpath...
ERROR: line over 90 characters
#50: FILE: linux-user/syscall.c:7503:
+ if(PATH_MAX < snprintf(proc_self_entry, sizeof(proc_self_entry),
"/proc/self/%s", entry)) {
ERROR: space required before the open parenthesis '('
#50: FILE: linux-user/syscall.c:7503:
+ if(PATH_MAX < snprintf(proc_self_entry, sizeof(proc_self_entry),
"/proc/self/%s", entry)) {
total: 2 errors, 0 warnings, 51 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
