Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171020232023.15010-1-richard.hender...@linaro.org
Subject: [Qemu-devel] [PATCH v7 00/52] tcg queued patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
884d9ecc0e translate-all: exit from tb_phys_invalidate if qht_remove fails
5fde6d4b84 tcg: Initialize cpu_env generically
2974513f3a tcg: enable multiple TCG contexts in softmmu
287c0c30eb tcg: introduce regions to split code_gen_buffer
8123f354e8 translate-all: use qemu_protect_rwx/none helpers
a30db9ff0c osdep: introduce qemu_mprotect_rwx/none
3d6d5fa011 tcg: allocate optimizer temps with tcg_malloc
2778d1ee80 tcg: distribute profiling counters across TCGContext's
87356c05ec tcg: introduce **tcg_ctxs to keep track of all TCGContext's
ef9818db6d gen-icount: fold exitreq_label into TCGContext
50f5f2f3f1 tcg: define tcg_init_ctx and make tcg_ctx a pointer
10f37e18e8 tcg: take tb_ctx out of TCGContext
fff2b30fe2 translate-all: report correct avg host TB size
b1439eb215 exec-all: rename tb_free to tb_remove
a9fd458664 translate-all: use a binary search tree to track TBs in TBContext
70db5d2de6 tcg: Remove CF_IGNORE_ICOUNT
f49f83484a tcg: Add CF_LAST_IO + CF_USE_ICOUNT to CF_HASH_MASK
065aeafb9f cpu-exec: lookup/generate TB outside exclusive region during
step_atomic
565a6a2f5f tcg: check CF_PARALLEL instead of parallel_cpus
3545bfea6f target/sparc: check CF_PARALLEL instead of parallel_cpus
0fd231d60c target/sh4: check CF_PARALLEL instead of parallel_cpus
d76f193124 target/s390x: check CF_PARALLEL instead of parallel_cpus
a702768279 target/m68k: check CF_PARALLEL instead of parallel_cpus
eabf5ec3b4 target/i386: check CF_PARALLEL instead of parallel_cpus
863f19b806 target/hppa: check CF_PARALLEL instead of parallel_cpus
d01c836399 target/arm: check CF_PARALLEL instead of parallel_cpus
6f7bcc5c01 tcg: convert tb->cflags reads to tb_cflags(tb)
79aa71931f tcg: Include CF_COUNT_MASK in CF_HASH_MASK
bd8596c990 tcg: Add CPUState cflags_next_tb
cc94b18e21 tcg: define CF_PARALLEL and use it for TB hashing along with
CF_COUNT_MASK
75e6d7cebe tcg: Use pointers in TCGOp->args
c9b3f0924d tcg: Use offsets not indices for TCGv_*
ec798e9206 qom: Introduce CPUClass.tcg_initialize
07d334ab75 tcg: Remove TCGV_EQUAL*
0c797b53b6 tcg: Remove GET_TCGV_* and MAKE_TCGV_*
a16c65dfae tcg: Introduce temp_tcgv_{i32, i64, ptr}
8dd304fc75 tcg: Introduce tcgv_{i32, i64, ptr}_{arg, temp}
42830c343d tcg: Push tcg_ctx into tcg_gen_callN
f3882e9866 tcg: Push tcg_ctx into generator functions
fe96411ca0 tcg: Use per-temp state data in optimize
51d3312359 tcg: Remove unused TCG_CALL_DUMMY_TCGV
ecafc3b927 tcg: Change temp_allocate_frame arg to TCGTemp
149bd61a00 tcg: Avoid loops against variable bounds
f3a420d6c8 tcg: Use per-temp state data in liveness
f6b3e73141 tcg: Introduce temp_arg, export temp_idx
0a764bd035 tcg: Return NULL temp for TCG_CALL_DUMMY_ARG
93d8c10d34 tcg: Add temp_global bit to TCGTemp
15b6c7ed39 tcg: Introduce arg_temp
0efe6827cc tcg: Propagate TCGOp down to allocators
3c56f4f96c tcg: Propagate args to op->args in tcg.c
a770b8d6fe tcg: Propagate args to op->args in optimizer
31da9faf36 tcg: Merge opcode arguments into TCGOp
=== OUTPUT BEGIN ===
Checking PATCH 1/52: tcg: Merge opcode arguments into TCGOp...
ERROR: spaces prohibited around that ':' (ctx:WxW)
#482: FILE: tcg/tcg.h:613:
+ unsigned calli : 4; /* 12 */
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#483: FILE: tcg/tcg.h:614:
+ unsigned callo : 2; /* 14 */
^
ERROR: space prohibited before that ':' (ctx:WxW)
#484: FILE: tcg/tcg.h:615:
+ unsigned : 2; /* 16 */
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#489: FILE: tcg/tcg.h:618:
+ unsigned prev : 16; /* 32 */
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#490: FILE: tcg/tcg.h:619:
+ unsigned next : 16; /* 48 */
^
total: 5 errors, 0 warnings, 485 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/52: tcg: Propagate args to op->args in optimizer...
ERROR: spaces required around that '-' (ctx:VxV)
#649: FILE: tcg/optimize.c:1165:
+ tcg_opt_gen_mov(s, op, op->args[0], op->args[4-tmp]);
^
total: 1 errors, 0 warnings, 912 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/52: tcg: Propagate args to op->args in tcg.c...
Checking PATCH 4/52: tcg: Propagate TCGOp down to allocators...
Checking PATCH 5/52: tcg: Introduce arg_temp...
Checking PATCH 6/52: tcg: Add temp_global bit to TCGTemp...
Checking PATCH 7/52: tcg: Return NULL temp for TCG_CALL_DUMMY_ARG...
Checking PATCH 8/52: tcg: Introduce temp_arg, export temp_idx...
Checking PATCH 9/52: tcg: Use per-temp state data in liveness...
WARNING: line over 80 characters
#187: FILE: tcg/tcg.c:1808:
+ } else if (arg_temp(op->args[0])->state == TS_DEAD &&
have_opc_new2) {
total: 0 errors, 1 warnings, 441 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/52: tcg: Avoid loops against variable bounds...
Checking PATCH 11/52: tcg: Change temp_allocate_frame arg to TCGTemp...
Checking PATCH 12/52: tcg: Remove unused TCG_CALL_DUMMY_TCGV...
Checking PATCH 13/52: tcg: Use per-temp state data in optimize...
Checking PATCH 14/52: tcg: Push tcg_ctx into generator functions...
Checking PATCH 15/52: tcg: Push tcg_ctx into tcg_gen_callN...
Checking PATCH 16/52: tcg: Introduce tcgv_{i32, i64, ptr}_{arg, temp}...
Checking PATCH 17/52: tcg: Introduce temp_tcgv_{i32, i64, ptr}...
Checking PATCH 18/52: tcg: Remove GET_TCGV_* and MAKE_TCGV_*...
Checking PATCH 19/52: tcg: Remove TCGV_EQUAL*...
Checking PATCH 20/52: qom: Introduce CPUClass.tcg_initialize...
Checking PATCH 21/52: tcg: Use offsets not indices for TCGv_*...
Checking PATCH 22/52: tcg: Use pointers in TCGOp->args...
Checking PATCH 23/52: tcg: define CF_PARALLEL and use it for TB hashing along
with CF_COUNT_MASK...
Checking PATCH 24/52: tcg: Add CPUState cflags_next_tb...
Checking PATCH 25/52: tcg: Include CF_COUNT_MASK in CF_HASH_MASK...
Checking PATCH 26/52: tcg: convert tb->cflags reads to tb_cflags(tb)...
ERROR: return is not a function, parentheses are not required
#103: FILE: target/alpha/translate.c:458:
+ return ((tb_cflags(ctx->base.tb) & CF_LAST_IO)
WARNING: line over 80 characters
#219: FILE: target/hppa/translate.c:472:
+ if ((tb_cflags(ctx->base.tb) & CF_LAST_IO) ||
ctx->base.singlestep_enabled) {
total: 1 errors, 1 warnings, 924 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 27/52: target/arm: check CF_PARALLEL instead of parallel_cpus...
Checking PATCH 28/52: target/hppa: check CF_PARALLEL instead of parallel_cpus...
Checking PATCH 29/52: target/i386: check CF_PARALLEL instead of parallel_cpus...
WARNING: line over 80 characters
#23: FILE: target/i386/translate.c:5310:
+ if ((s->prefix & PREFIX_LOCK) && (tb_cflags(s->base.tb) &
CF_PARALLEL)) {
WARNING: line over 80 characters
#32: FILE: target/i386/translate.c:5321:
+ if ((s->prefix & PREFIX_LOCK) && (tb_cflags(s->base.tb) &
CF_PARALLEL)) {
total: 0 errors, 2 warnings, 16 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 30/52: target/m68k: check CF_PARALLEL instead of parallel_cpus...
Checking PATCH 31/52: target/s390x: check CF_PARALLEL instead of
parallel_cpus...
Checking PATCH 32/52: target/sh4: check CF_PARALLEL instead of parallel_cpus...
Checking PATCH 33/52: target/sparc: check CF_PARALLEL instead of
parallel_cpus...
Checking PATCH 34/52: tcg: check CF_PARALLEL instead of parallel_cpus...
Checking PATCH 35/52: cpu-exec: lookup/generate TB outside exclusive region
during step_atomic...
Checking PATCH 36/52: tcg: Add CF_LAST_IO + CF_USE_ICOUNT to CF_HASH_MASK...
Checking PATCH 37/52: tcg: Remove CF_IGNORE_ICOUNT...
Checking PATCH 38/52: translate-all: use a binary search tree to track TBs in
TBContext...
Checking PATCH 39/52: exec-all: rename tb_free to tb_remove...
Checking PATCH 40/52: translate-all: report correct avg host TB size...
Checking PATCH 41/52: tcg: take tb_ctx out of TCGContext...
Checking PATCH 42/52: tcg: define tcg_init_ctx and make tcg_ctx a pointer...
Checking PATCH 43/52: gen-icount: fold exitreq_label into TCGContext...
Checking PATCH 44/52: tcg: introduce **tcg_ctxs to keep track of all
TCGContext's...
Checking PATCH 45/52: tcg: distribute profiling counters across TCGContext's...
Checking PATCH 46/52: tcg: allocate optimizer temps with tcg_malloc...
Checking PATCH 47/52: osdep: introduce qemu_mprotect_rwx/none...
Checking PATCH 48/52: translate-all: use qemu_protect_rwx/none helpers...
Checking PATCH 49/52: tcg: introduce regions to split code_gen_buffer...
Checking PATCH 50/52: tcg: enable multiple TCG contexts in softmmu...
Checking PATCH 51/52: tcg: Initialize cpu_env generically...
ERROR: do not initialise globals to 0 or NULL
#645: FILE: tcg/tcg.c:124:
+TCGv_env cpu_env = 0;
total: 1 errors, 0 warnings, 567 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 52/52: translate-all: exit from tb_phys_invalidate if qht_remove
fails...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
