Am 20.10.2017 um 20:24 schrieb alind...@codeaurora.org: > On 2017-10-20 05:27, Peter Maydell wrote: >> On 19 October 2017 at 21:04, Aaron Lindsay <alind...@codeaurora.org> >> wrote: >>> I get the following error when building on an NFSv3 filesystem: >>> >>> % make -j8 >>> GEN aarch64-softmmu/config-devices.mak.tmp >>> GEN config-host.h >>> [snip] >>> GEN qmp-marshal.c >>> GEN aarch64-softmmu/config-devices.mak >>> cp: preserving permissions for >>> ‘aarch64-softmmu/config-devices.mak.old’: Operation not supported >>> make: *** Deleting file `aarch64-softmmu/config-devices.mak' >>> GEN qapi-types.c >>> [snip] >>> CC scsi/qemu-pr-helper.o >>> make: *** No rule to make target `config-all-devices.mak', needed by >>> `subdir-aarch64-softmmu'. Stop. >>> make: *** Waiting for unfinished jobs.... >>> >>> Ideally you would only build on a filesystem with proper support, but >>> I haven't >>> been able to find a reason why preserving exact permissions is >>> important in >>> this case. >> >> Do we even need this code at all? As far as I can tell from >> the git logs, the idea is to support users who hand-modify >> config-devices.mak. But do we want to support that? I would >> think of config-devices.mak as an internal part of the build >> machinery, and the bit you can edit as a user is the stuff >> in default-configs/.
It's a long time since I wrote that code, but when I look at the commit message for my commit 012f0879234, it was written for users who do _not_ hand-modify config-devices.mak. They had a problem when they updated the code from git and the new version had changed some of the device configurations which were used to build config-devices.mak. So maybe that code is still needed because device configurations change sometimes. Regards, Stefan > I haven't ever found a reason to modify config-devices.mak and > just assumed others had. Its existence doesn't bother me, but I > can also see the argument to simplify if it's unused. Would you > prefer I resubmit a patch removing it instead? > > -Aaron >
