On 10/20/2017 01:31 PM, Cornelia Huck wrote:
> On Fri, 20 Oct 2017 12:25:17 +0200
> Christian Borntraeger <borntrae...@de.ibm.com> wrote:
>
>> From: "Collin L. Walling" <wall...@linux.vnet.ibm.com>
>>
>> The sclp console in the s390 bios writes raw data,
>> leading console emulators (such as virsh console) to
>> treat a new line ('\n') as just a new line instead
>> of as a Unix line feed. Because of this, output
>> appears in a "stair case" pattern.
>>
>> Let's print \r\n on every occurrence of a new line
>> in the string passed to write to amend this issue.
>>
>> This is in sync with the guest Linux code in
>> drivers/s390/char/sclp_vt220.c which also does a line feed
>> conversion in the console part of the driver.
>>
>> This fixes the s390-ccw and s390-netboot output like
>> $ virsh start test --console
>> Domain test started
>> Connected to domain test
>> Escape character is ^]
>> Network boot starting...
>> Using MAC address: 02:01:02:03:04:05
>> Requesting
>> information via DHCP: 010
>>
>> Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
>> ---
>> pc-bios/s390-ccw/s390-ccw.h | 3 +++
>> pc-bios/s390-ccw/sclp.c | 17 ++++++++++++++---
>> 2 files changed, 17 insertions(+), 3 deletions(-)
>
> I'd defer that to a second pullreq before softfreeze where we can
> collect the stragglers (currently building a pullreq). And I'd also
> like to delegate that second pullreq to you, as I'll be busy/offline
> after KVM Forum.
Sure I can do that in a 2nd pull req after KVM forum.
