Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171017001209.32276-1-f4...@amsat.org
Subject: [Qemu-devel] [PATCH v2 00/39] remove i386/pc dependency from non-PC
world (part 1)
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f9b5adbc98 hw/dma/i8257: rename DMA_init() to i8257_dma_init()
f71e39caef hw/dma/i82374: avoid multiple creations on the same ISA bus
9585ff27ee i386/pc: extract port92 from pc.c
90a6650cc2 i386/pc: move pvpanic.c from hw/misc/ to hw/i386/
369359d0a3 i386/pc: move vmport.c from hw/misc/ to hw/i386/
d1ba052e40 misc: drop old i386 dependency
e37ece0e66 hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c
61e5432dfb hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init()
2527adbd94 hw/input/i8042: extract pckbd and vmmouse API from hw/i386/pc.h
e4aea69c57 hw/display/vga: remove the old i386/pc dependency
00c2b51282 hw/timer/i8254: rename pit_init() -> i8254_pit_init()
5a2da30911 hw/acpi: ACPI_PM_* defines are not restricted to i386 arch
d98f86ddce hw/unicore32: restrict hw addr defines to source file
ba587df9c6 hw/virtio-balloon: remove old i386 dependency
84e024931c hw/tpm: remove old i386 dependency
d31e2f2f97 hw/i2c: remove old i386 dependency
f2aaf9bc2a hw/ipmi: remove old i386 dependency
3d0323ecf5 hw/ide: remove old i386 dependency
b63727fb07 misc: remove old i386 dependency
3994d07ab1 amd_iommu: avoid needless includes in header file
7078fefc0d hw/ssi/aspeed_smc: remove unused #include
bf36f5ce1c numa: remove unused #include
5dd3e81161 misc: avoid "include/" in include path
d5046be308 nios2: remove duplicated includes (in code commented out)
999900c18c i386/hax: remove duplicated include
1882d51635 i386/hax: remove duplicated includes
31d4286735 ppc: remove duplicated includes
9e4ff5d6ad misc: remove duplicated includes
4fb941d5e4 misc: remove headers implicitly included
9f2acbf8db block: remove "qemu/osdep.h" from header file
ab3541d145 hw: remove "qemu/osdep.h" from header files
28ea036b9d hw: use "qemu/osdep.h" as first #include in source files
b64abefcca MAINTAINERS: add missing entry for include/hw/net/
fa9867686a MAINTAINERS: add entries for timer/m48t59
a2a554cf84 MAINTAINERS: add an entry for input/pckbd.c
b9686a0469 MAINTAINERS: add an entry for watchdog/wdt_ib700
bc4ab23aa5 MAINTAINERS: add an entry for the i82378 (superio)
ff635651e6 MAINTAINERS: add entries for dma/i82374
d4624ea37e MAINTAINERS: add entries for i2c/ppc4xx_i2c
=== OUTPUT BEGIN ===
Checking PATCH 1/39: MAINTAINERS: add entries for i2c/ppc4xx_i2c...
Checking PATCH 2/39: MAINTAINERS: add entries for dma/i82374...
Checking PATCH 3/39: MAINTAINERS: add an entry for the i82378 (superio)...
Checking PATCH 4/39: MAINTAINERS: add an entry for watchdog/wdt_ib700...
Checking PATCH 5/39: MAINTAINERS: add an entry for input/pckbd.c...
Checking PATCH 6/39: MAINTAINERS: add entries for timer/m48t59...
Checking PATCH 7/39: MAINTAINERS: add missing entry for include/hw/net/...
Checking PATCH 8/39: hw: use "qemu/osdep.h" as first #include in source files...
Checking PATCH 9/39: hw: remove "qemu/osdep.h" from header files...
Checking PATCH 10/39: block: remove "qemu/osdep.h" from header file...
Checking PATCH 11/39: misc: remove headers implicitly included...
Checking PATCH 12/39: misc: remove duplicated includes...
Checking PATCH 13/39: ppc: remove duplicated includes...
Checking PATCH 14/39: i386/hax: remove duplicated includes...
Checking PATCH 15/39: i386/hax: remove duplicated include...
Checking PATCH 16/39: nios2: remove duplicated includes (in code commented
out)...
Checking PATCH 17/39: misc: avoid "include/" in include path...
Checking PATCH 18/39: numa: remove unused #include...
Checking PATCH 19/39: hw/ssi/aspeed_smc: remove unused #include...
Checking PATCH 20/39: amd_iommu: avoid needless includes in header file...
Checking PATCH 21/39: misc: remove old i386 dependency...
Checking PATCH 22/39: hw/ide: remove old i386 dependency...
Checking PATCH 23/39: hw/ipmi: remove old i386 dependency...
Checking PATCH 24/39: hw/i2c: remove old i386 dependency...
Checking PATCH 25/39: hw/tpm: remove old i386 dependency...
Checking PATCH 26/39: hw/virtio-balloon: remove old i386 dependency...
Checking PATCH 27/39: hw/unicore32: restrict hw addr defines to source file...
Checking PATCH 28/39: hw/acpi: ACPI_PM_* defines are not restricted to i386
arch...
Checking PATCH 29/39: hw/timer/i8254: rename pit_init() -> i8254_pit_init()...
Checking PATCH 30/39: hw/display/vga: remove the old i386/pc dependency...
Checking PATCH 31/39: hw/input/i8042: extract pckbd and vmmouse API from
hw/i386/pc.h...
Checking PATCH 32/39: hw/timer/mc146818: rename rtc_init() ->
mc146818_rtc_init()...
Checking PATCH 33/39: hw/net/ne2000: extract ne2k-isa code from i386/pc to
ne2000-isa.c...
Checking PATCH 34/39: misc: drop old i386 dependency...
Checking PATCH 35/39: i386/pc: move vmport.c from hw/misc/ to hw/i386/...
Checking PATCH 36/39: i386/pc: move pvpanic.c from hw/misc/ to hw/i386/...
Checking PATCH 37/39: i386/pc: extract port92 from pc.c...
ERROR: do not use C99 // comments
#202: FILE: hw/i386/port92.c:24:
+ //DPRINTF("port92: write 0x%02" PRIx64 "\n", val);
ERROR: do not use C99 // comments
#217: FILE: hw/i386/port92.c:39:
+ //DPRINTF("port92: read 0x%02x\n", ret);
total: 2 errors, 0 warnings, 280 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 38/39: hw/dma/i82374: avoid multiple creations on the same ISA
bus...
Checking PATCH 39/39: hw/dma/i8257: rename DMA_init() to i8257_dma_init()...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
