On 17.10.2017 02:12, Philippe Mathieu-Daudé wrote: > - move the header from hw/isa/ to hw/dma/ > - remove the old i386/pc dependency > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > include/hw/{isa/i8257.h => dma/i8257_dma.h} | 6 ++++++ > include/hw/isa/isa.h | 2 -- > hw/dma/i82374.c | 3 ++- > hw/dma/i8257.c | 4 ++-- > hw/i386/pc.c | 3 ++- > hw/mips/mips_fulong2e.c | 3 ++- > hw/mips/mips_jazz.c | 3 ++- > hw/mips/mips_malta.c | 3 ++- > hw/sparc/sun4m.c | 4 ---- > hw/sparc64/sun4u.c | 4 ---- > 10 files changed, 18 insertions(+), 17 deletions(-) > rename include/hw/{isa/i8257.h => dma/i8257_dma.h} (86%) > > diff --git a/include/hw/isa/i8257.h b/include/hw/dma/i8257_dma.h > similarity index 86% > rename from include/hw/isa/i8257.h > rename to include/hw/dma/i8257_dma.h
I think you could drop the "_dma" suffix from the name - it is already in a folder called "dma", so the context of this file should be clear already. Thomas