On Fri, Oct 13, 2017 at 10:14:39AM +0200, Gerd Hoffmann wrote: > The following changes since commit bac960832015bf4c4c1b873011612e2675e4464c: > > Merge remote-tracking branch 'remotes/elmarco/tags/vus-pull-request' into > staging (2017-10-11 13:10:36 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20171013-pull-request > > for you to fetch changes up to 942a35335b2efa2f2997d51eb5142fc9903efe43: > > gtk: fix wrong id between texture and framebuffer (2017-10-13 10:10:36 > +0200) > > ---------------------------------------------------------------- > ui: use keycodemapdb for key code mappings, part one (v2) > ui: add qemu-keymap, update reverse keymaps (for qemu -k $map) > ui: fix for vte 0.50 > ui: gtk texture fix > > ----------------------------------------------------------------
I'm afraid this is quite likely to fail build smoke test again. I've just tried a build on OpenBSD with the bash -> sh fix in it, and I found that it still tried to build the keycodemap files in parallel with checking out the GIT submodules. It also tried to run the mkdir -p dtc/libfdt in parallel and this caused git to refuse to checkout the dtc module due to that empty dir existing. So there's still some deps problems in here I think that let make build in the wrong order :-( GEN config-host.h GEN module_block.h GEN ui/input-keymap-linux-to-qcode.c GEN ui/input-keymap-qcode-to-qnum.c GEN ui/input-keymap-qnum-to-qcode.c python: can't open file '/home/berrange/src/virt/qemu/ui/keycodemapdb/tools/keymap-gen': [Errno 2] No such file or directory python: can't open file '/home/berrange/src/virt/qemu/ui/keycodemapdb/tools/keymap-gen': [Errno 2] No such file or directory python: can't open file '/home/berrange/src/virt/qemu/ui/keycodemapdb/tools/keymap-gen': [Errno 2] No such file or directory mkdir -p dtc/libfdt GIT ui/keycodemapdb dtc mkdir -p dtc/tests This should be impossible because ui/input-keymap-* depends on the tools/keymap-gen, and that depends on the submodule status file, which in turn should trigger the checkout, but the build log showed that isn't working as we expect. In all my debugging the one thing I've seen work correctly is the re-running of configure (via config.status), which always happens earlier and is serialized wrt everything else. So I wonder if we should change direction slightly, and have configure checkout the submodules. Then just make sure that config.status is triggered when submodules are out of date. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
