On Wed, Oct 11, 2017 at 04:52:03PM +0100, Ross Lagerwall wrote:
> xen_modified_memory() sets errno to communicate what went wrong so log
> this rather than the return value which is not interesting.
>
> Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com>
> ---
> hw/i386/xen/xen-hvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index d9ccd5d..8028bed 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hvm.c
> @@ -1446,7 +1446,7 @@ void xen_hvm_modified_memory(ram_addr_t start,
> ram_addr_t length)
> if (rc) {
> fprintf(stderr,
> "%s failed for "RAM_ADDR_FMT" ("RAM_ADDR_FMT"): %i,
> %s\n",
> - __func__, start, nb_pages, rc, strerror(-rc));
> + __func__, start, nb_pages, errno, strerror(errno));
> }
> }
> }
There is already a patch, not applied yet for it,
https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07541.html
with the only difference is printing the value of rc and not errno (both
patch user errno for strerror).
I guess this patch is better, so
Acked-by: Anthony PERARD <anthony.per...@citrix.com>
Thanks,
--
Anthony PERARD
