Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171010005600.28735-1-richard.hender...@linaro.org
Subject: [Qemu-devel] [PULL 00/23] Queued TCG patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
020092218c tcg/mips: delete commented out extern keyword.
a930780721 tcg: define TCG_HIGHWATER
8026884b71 translate-all: use qemu_protect_rwx/none helpers
f3551e886a osdep: introduce qemu_mprotect_rwx/none
45f0d767ee util: move qemu_real_host_page_size/mask to osdep.h
4f577fe397 tcg: allocate optimizer temps with tcg_malloc
375a903a67 tcg: take .helpers out of TCGContext
4acd817a39 tci: move tci_regs to tcg_qemu_tb_exec's stack
b9643c7783 exec-all: extract tb->tc_* into a separate struct tc_tb
69b39c3c13 translate-all: define and use DEBUG_TB_CHECK_GATE
6677e87257 translate-all: define and use DEBUG_TB_INVALIDATE_GATE
71fe5680f0 exec-all: introduce TB_PAGE_ADDR_FMT
de8d4a9e3b translate-all: define and use DEBUG_TB_FLUSH_GATE
ae75a5b9b4 exec-all: bring tb->invalid into tb->cflags
2aa396f6fd tcg: consolidate TB lookups in tb_lookup__cpu_state
b69aa5f5f1 tcg: remove addr argument from lookup_tb_ptr
36675fa971 tcg/mips: constify tcg_target_callee_save_regs
d25ed95039 tcg/i386: constify tcg_target_callee_save_regs
84434ebc84 cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find
0d8bb601a8 translate-all: make have_tb_lock static
d77ef85297 exec-all: fix typos in TranslationBlock's documentation
7fa23b519f tcg: fix corruption of code_time profiling counter upon tb_flush
6e75a57d69 cputlb: bring back tlb_flush_count under !TLB_DEBUG
=== OUTPUT BEGIN ===
Checking PATCH 1/23: cputlb: bring back tlb_flush_count under !TLB_DEBUG...
Checking PATCH 2/23: tcg: fix corruption of code_time profiling counter upon
tb_flush...
Checking PATCH 3/23: exec-all: fix typos in TranslationBlock's documentation...
Checking PATCH 4/23: translate-all: make have_tb_lock static...
Checking PATCH 5/23: cpu-exec: rename have_tb_lock to acquired_tb_lock in
tb_find...
Checking PATCH 6/23: tcg/i386: constify tcg_target_callee_save_regs...
Checking PATCH 7/23: tcg/mips: constify tcg_target_callee_save_regs...
Checking PATCH 8/23: tcg: remove addr argument from lookup_tb_ptr...
Checking PATCH 9/23: tcg: consolidate TB lookups in tb_lookup__cpu_state...
Checking PATCH 10/23: exec-all: bring tb->invalid into tb->cflags...
Checking PATCH 11/23: translate-all: define and use DEBUG_TB_FLUSH_GATE...
Checking PATCH 12/23: exec-all: introduce TB_PAGE_ADDR_FMT...
Checking PATCH 13/23: translate-all: define and use DEBUG_TB_INVALIDATE_GATE...
Checking PATCH 14/23: translate-all: define and use DEBUG_TB_CHECK_GATE...
Checking PATCH 15/23: exec-all: extract tb->tc_* into a separate struct tc_tb...
Checking PATCH 16/23: tci: move tci_regs to tcg_qemu_tb_exec's stack...
Checking PATCH 17/23: tcg: take .helpers out of TCGContext...
Checking PATCH 18/23: tcg: allocate optimizer temps with tcg_malloc...
Checking PATCH 19/23: util: move qemu_real_host_page_size/mask to osdep.h...
Checking PATCH 20/23: osdep: introduce qemu_mprotect_rwx/none...
Checking PATCH 21/23: translate-all: use qemu_protect_rwx/none helpers...
Checking PATCH 22/23: tcg: define TCG_HIGHWATER...
Checking PATCH 23/23: tcg/mips: delete commented out extern keyword....
ERROR: externs should be avoided in .c files
#22: FILE: tcg/mips/tcg-target.inc.c:39:
+int link_error(void);
total: 1 errors, 0 warnings, 8 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
