On 10/06/2017 05:13 PM, Peter Maydell wrote: > On 20 September 2017 at 08:01, Cédric Le Goater <c...@kaod.org> wrote: >> Hello, >> >> This series adds a new Aspeed machine to emulate the BMC of a >> Witherspoon system. It also extends the other Aspeed machines with I2C >> devices and adds a simple model for the pca9552 LED blinker present on >> the witherspoon board. >> >> Thanks, >> >> C. >> >> Changes since v1: >> >> - introduced smbus_eeprom_init_one() >> >> Cédric Le Goater (6): >> aspeed: add support for the witherspoon-bmc board >> aspeed: add an I2C RTC device to all machines >> smbus: add a smbus_eeprom_init_one() routine >> aspeed: Add EEPROM I2C devices >> misc: add pca9552 LED blinker model >> aspeed: add the pc9552 chips to the witherspoon machine > > Hi -- I've made a couple of review comments and nothing else > leapt out as obviously wrong, but I'm hoping that somebody more > familiar with the aspeed devices will do review...
Joel, Now that we have updated the DTs, could you please take a look to make sure that the I2C busses in the models have devices which makes sense with the real boards. Thanks, C.
