On Thu, Oct 05, 2017 at 06:24:28PM +0200, Igor Mammedov wrote: > type_register()/type_register_static() functions in current impl. > can't fail returning 0, also none of the users check for error > so update doc comment to reflect current behaviour. > > Suggested-by: Eduardo Habkost <ehabk...@redhat.com> > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > Reviewed-by: Eduardo Habkost <ehabk...@redhat.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > --- > include/qom/object.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/qom/object.h b/include/qom/object.h > index e0d9824..a707b67 100644 > --- a/include/qom/object.h > +++ b/include/qom/object.h > @@ -773,7 +773,7 @@ const char *object_get_typename(const Object *obj); > * @info and all of the strings it points to should exist for the life time > * that the type is registered. > * > - * Returns: 0 on failure, the new #Type on success. > + * Returns: the new #Type. > */ > Type type_register_static(const TypeInfo *info); > > @@ -784,7 +784,7 @@ Type type_register_static(const TypeInfo *info); > * Unlike type_register_static(), this call does not require @info or its > * string members to continue to exist after the call returns. > * > - * Returns: 0 on failure, the new #Type on success. > + * Returns: the new #Type. > */ > Type type_register(const TypeInfo *info); > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature