On 10/05/2017 12:32 PM, Richard Henderson wrote: > if (env->regs[15] & 1) { > if (!arm_feature(env, ARM_FEATURE_V8)) { > qemu_log_mask(...); > } > env->regs[15] &= ~1U; > }
Bah. Even better to move the bit clear statement before the feature check. The two loads from env->regs[15] will no longer be separated by a function call and therefore CSEd by the compiler. r~