On Tue, Sep 26, 2017 at 08:35:59PM +0100, Peter Maydell wrote: > On 26 September 2017 at 20:31, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Mon, Sep 25, 2017 at 12:06:40AM +0300, Michael Tokarev wrote: > >> 22.09.2017 06:06, Thomas Huth wrote: > >> > If QEMU has been compiled with the flags --enable-tcg-interpreter and > >> > --enable-debug, the guest is running incredibly slow. The pxe boot test > >> > can take up to 400 seconds when testing the pseries ppc64 machine. While > >> > we should still look for ways to speed up the test on the pseries > >> > machine, > >> > it's better to increase the timeout in this test to 600 seconds anyway to > >> > allow the test to pass successfully now with this unusal configuration > >> > already. > >> > >> Applied to -trivial, thanks! > >> > >> /mjt > > > > Please do not apply this, trivial is not appropriate for functional > > changes like this. > > It's not a functional change, it's just bumping a test timeout. > If you think we should be doing something else that's fine (as > with any other patch), but in principle I think this is totally > fine as a -trivial patch. > > thanks > -- PMM
OK. I'd rather not see it applied as-is though. -- MST
