On Tue, Sep 26, 2017 at 09:53:44AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Sep 21, 2017 at 06:51:37PM +0100, Dr. David Alan Gilbert wrote:
[...] > > > > @@ -1969,6 +2002,10 @@ static int qemu_loadvm_state_main(QEMUFile *f, > > > > MigrationIncomingState *mis) > > > > goto out; > > > > } > > > > break; > > > > + case QEMU_VM_EOF: > > > > + /* This is the end of migration */ > > > > + goto out; > > > > + break; > > > > > > You don't need the goto and the break (although it does no harm). > > > > I still need the goto to break the loop? (I think a single break will > > only break the select, but not the loop) > > > > If I remove both "goto" and "break", it'll fall through to default, I > > suppose that's not what we want? > > No, but if you have the 'goto' you don't need the 'break'. I see. Let me remove the "break" after "goto" then. Thanks, -- Peter Xu
