26.09.2017 02:22, Peter Maydell wrote:
[]
>> trivial patches for 2017-09-25
>
> This fails 'make check' on most of my configs:
>
> GTESTER check-qtest-ppc64
> qemu-system-ppc64: -object
> filter-mirror,id=qtest-f0,netdev=qtest-bn0,queue=tx,outdev=mirror0:
> Device 'qtest-bn0' not found
> Broken pipe
> GTester: last random seed: R02Sb816ff80b7d08ef6a5328ff373d8cd65
>
> GLib-CRITICAL **: void g_hook_destroy_link(GHookList *, GHook *):
> assertion `hook != NULL' failed
> aborting...
For what it's worth, this time I just _forgot_ to run tests. What a shame..
It fails due to:
Author: Eduardo Otubo <ot...@redhat.com>
Date: Mon Aug 21 17:50:05 2017 +0200
filter-mirror: segfault when specifying non existent device
When using filter-mirror like the example below where the interface
'ndev0' does not exist on the host, QEMU crashes into segmentation
fault.
$ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object
filter-mirror,id=test-object,netdev=ndev0
This happens because the function filter_mirror_setup() does not checks
if the device actually exists and still keep on processing calling
qemu_chr_find(). This patch fixes this issue.
Signed-off-by: Eduardo Otubo <ot...@redhat.com>
Reviewed-by: Zhang Chen <zhangchen.f...@cn.fujitsu.com>
Reverting this patch makes it run again. Cc'ing Eduardo.
I'll remove this patch, patch "hw/isa/pc87312: Mark the device with
user_creatable = false" (will be replaced with a better variant),
and update another patch stripping one more trailing whitespace,
and resend.
Thanks,
/mjt
