On 09/20/2017 10:25 AM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 15:47:51 +0800 > Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> wrote: > >> * Halil Pasic <pa...@linux.vnet.ibm.com> [2017-09-19 20:27:44 +0200]: > >>> @@ -828,7 +836,9 @@ void ccw_dstream_init(CcwDataStream *cds, CCW1 const >>> *ccw, ORB const *orb) >>> g_assert(!(orb->ctrl1 & ORB_CTRL1_MASK_MIDAW)); >>> cds->flags = (orb->ctrl0 & ORB_CTRL0_MASK_I2K ? CDS_F_I2K : 0) | >>> (orb->ctrl0 & ORB_CTRL0_MASK_C64 ? CDS_F_C64 : 0) | >>> + (orb->ctrl0 & ORB_CTRL0_MASK_FMT ? CDS_F_FMT : 0) | >> This reminds me one more question: >> Calling ccw_dsteram_init() after copy_ccw_from_guest() may lead to a >> fmt-1 @ccw with an @orb that designates fmt-0 ccw. This sounds insane. > > That's just a consequence of us translating everything to format-1 > ccws. A bit confusing, but no problem if we pay attention to the format > bit everywhere it makes a difference. >
Agree. Halil
