On 09/19/2017 04:16 PM, Eric Blake wrote:
> Although none of the existing macro call-sites were broken,
> it's always better to write macros that properly parenthesize
> arguments that can be complex expressions, so that the intended
> order of operations is not broken.
yes.
> Signed-off-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Cédric Le Goater <c...@kaod.org>
C.
> ---
> include/hw/ppc/pnv_xscom.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index 3757b2cab9..38077b4796 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -54,7 +54,7 @@ typedef struct PnvXScomInterfaceClass {
> * PCB SLAVE 0x110Fxxxx
> */
>
> -#define PNV_XSCOM_EX_CORE_BASE(base, i) (base | (((uint64_t)i) << 24))
> +#define PNV_XSCOM_EX_CORE_BASE(base, i) ((base) | ((uint64_t)(i) << 24))
> #define PNV_XSCOM_EX_CORE_SIZE 0x100000
>
> #define PNV_XSCOM_LPC_BASE 0xb0020
>
