On 09/16/2017 01:51 PM, Max Reitz wrote: > Add a new test file (check-qobject.c) for unit tests that concern > QObjects as a whole. > > Its only purpose for now is to test the qobject_is_equal() function. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > tests/Makefile.include | 4 +- > tests/check-qobject.c | 315 > +++++++++++++++++++++++++++++++++++++++++++++++++
We're not entirely consistent on our testsuite naming, although I'm fine with your choice [and there's still the idea floating around in another thread to split tests into subdirectories by whether they are part of check-unit or check-qtest]. However, the check-* notation cannot be automatically covered by .gitignore the way a -test suffix is, so you're missing a change to tests/.gitignore covering the new test in an in-tree build. We have the idea floating around that we want to outlaw in-tree builds altogether [although I'm not sold on that yet], and/or to generate .gitignore, but until those land, it doesn't hurt to keep .gitignore up-to-date. So with that addition, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
