On 09/15/2017 12:45 AM, Fam Zheng wrote: > So it is easier to copy paste the path. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > tests/qemu-iotests/check | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index d504b6e455..4583a0c269 100755 > --- a/tests/qemu-iotests/check > +++ b/tests/qemu-iotests/check > @@ -353,7 +353,7 @@ do > else > echo " - output mismatch (see $seq.out.bad)" > mv $tmp.out $seq.out.bad > - $diff -w "$reference" $seq.out.bad > + $diff -w "$reference" $(realpath $seq.out.bad)
Realpath collapses symlinks, and $() costs a process. Also, your patch fails miserably if the current working directory contains spaces; you forgot to quote $(). It would be simpler, and more correct, to do: $diff -w "$reference" "$PWD/$seq.out.bad" -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
