On 12.09.2017 16:46, Greg Kurz wrote: > On Tue, 12 Sep 2017 16:01:46 +0200 > Laurent Vivier <lviv...@redhat.com> wrote: > >> Fix aarch64 and ppc when dump-guest-memory is >> used with none machine type and no CPU. >> >> The other machine types don't have the problem. >> >> Update test-hmp, to test none machine type >> with (2 MB) and without memory, and add a test >> to test dump-quest-memory without filter parameters >> (it needs the fix from Cornelia Huck to work) >> >> v3: >> - remove blank line after a comment >> - forbid memory dump when there is no CPU >> > > So in the end, we would forbid dump on aarch64 and > ppc, while it is allowed on i386... I don't really > care about which behavior is more appropriate but > I guess they should be consistent at least.
It's kind of consistent: Allow it on architectures with fixed endianess, but disallow it on architectures without fixed endianess ;-) Honestly, it should not matter - we're talking here about the "none" machine without a CPU ... as long as it does not crash, there is no need for a working "dump-guest-memory" function here. Thomas
signature.asc
Description: OpenPGP digital signature
