On 11.09.2017 16:20, Laurent Vivier wrote:
> and add a test case of dump-guest-memory without
> "[begin length]" parameters.
>
> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
> ---
> tests/test-hmp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/test-hmp.c b/tests/test-hmp.c
> index 729c0339f7..90693c0ce2 100644
> --- a/tests/test-hmp.c
> +++ b/tests/test-hmp.c
> @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = {
> "mouse_button 0",
> "device_del mouse1",
> "dump-guest-memory /dev/null 0 4096",
> + "dump-guest-memory /dev/null",
> "gdbserver",
> "host_net_add user id=net0",
> "hostfwd_add tcp::43210-:43210",
> @@ -159,5 +160,9 @@ int main(int argc, char **argv)
>
> qtest_cb_for_every_machine(add_machine_test_case);
>
> + /* as none machine has no memory, add a test case with memory */
> +
Maybe remove the empty line after the comment?
> + qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine);
> +
> return g_test_run();
> }
>
Reviewed-by: Thomas Huth <th...@redhat.com>
