On 04.09.2017 17:42, David Hildenbrand wrote: > All but a handfull of filles include exec/cpu-all.h via cpu.h only. > As these files already include cpu.h, let's just drop the additional > include. > > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > dump.c | 1 - > exec.c | 2 -- > target/i386/arch_dump.c | 1 - > target/i386/arch_memory_mapping.c | 1 - > target/i386/svm_helper.c | 1 - > target/ppc/arch_dump.c | 1 - > target/s390x/arch_dump.c | 1 - > 7 files changed, 8 deletions(-) > > diff --git a/dump.c b/dump.c > index a79773d0f7..2ef6a678e8 100644 > --- a/dump.c > +++ b/dump.c > @@ -15,7 +15,6 @@ > #include "qemu/cutils.h" > #include "elf.h" > #include "cpu.h" > -#include "exec/cpu-all.h" > #include "exec/hwaddr.h" > #include "monitor/monitor.h" > #include "sysemu/kvm.h" > diff --git a/exec.c b/exec.c > index d20c34ca83..d109de2014 100644 > --- a/exec.c > +++ b/exec.c > @@ -23,7 +23,6 @@ > > #include "qemu/cutils.h" > #include "cpu.h" > -#include "exec/exec-all.h"
You should maybe mention exec-all.h in the patch description, too. (I think it can be dropped here because it is included by translate-all.h already). If you tweak the patch description: Reviewed-by: Thomas Huth <th...@redhat.com>
