On 09/04/2017 09:03 AM, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> Right now, tests/multiboot is not run by default during 'make check'; >> but when it is run in-tree, it was leaving some junk behind that could >> accidentally get checked in with a careless 'git add tests'. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> --- >> tests/.gitignore | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/.gitignore b/tests/.gitignore >> index fed0189a5a..64ecd6683b 100644 >> --- a/tests/.gitignore >> +++ b/tests/.gitignore >> @@ -10,6 +10,8 @@ check-qnull >> check-qstring >> check-qom-interface >> check-qom-proplist >> +multiboot/test.out > > Your patch is of course a good idea ... but that test.out smells quite > bad ... I guess it should (a) use mktemp for a better file name instead > so that we can run this in parallel and (b) clean up the temporary file > once the test has been done?
Indeed, making multiboot better, and run by default under 'make check', is a better task than just tweaking .gitignore, but one orthogonal enough to my libqtest changes that I will save this patch (and 2/29) for another series (or if someone else wants to tackle it first). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
