On Tue, Sep 05, 2017 at 11:10:55AM -0400, Brian Steffens wrote: > > Have you considered extending the 'migrate' command with a list of > > drives instead? > > That was my original plan but I thought having information on whether a > device is shared or not could potentially be useful to other systems. If > not then you're right, it would be a lighter touch to add it only to the > 'migrate' command.
I agree with Fam that bs->shared doesn't necessarily have the same meaning to everyone. Therefore I suggest extending the 'migrate' command instead. > > In case you haven't seen it, the preferred approach for non-shared > > storage migration is drive-mirror + NBD. The block/migration.c code is > > an older feature that is less flexible. More info on drive-mirror + > > NBD: > > I didn't realize drive-mirror + NBD was the preferred approach. Are > there any plans to drop support for the block/migration.c style? migration/block.c is not formally deprecated yet. It's still used by libvirt in situations where NBD connections are not desirable. Eventually it will probably be deprecated and then removed after 2 more QEMU releases according to the deprecation policy (see qemu-doc.texi). Stefan
