Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> writes: > At least in some configurations, setting c-file-style is not enough to > conform to the QEMU coding style, so explicitly set c-basic-offset as well. > > Signed-off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> > --- > > My emacs was using indentation level of 8 spaces and this patch convinced > it to use the correct value. > > I set c-basic-offset set to tab-width in my ~/.spacemacs which perhaps > isn't the wisest thing to do, but since there's a .dir-locals.el we can > make the editor always do the right thing.
I think some of this rationale should be worked into the commit message if we decide the patch makes sense. > .dir-locals.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.dir-locals.el b/.dir-locals.el > index 3ac0cfc6f0d6..8e47418c5996 100644 > --- a/.dir-locals.el > +++ b/.dir-locals.el > @@ -1,2 +1,3 @@ > ((c-mode . ((c-file-style . "stroustrup") > - (indent-tabs-mode . nil)))) > + (indent-tabs-mode . nil) > + (c-basic-offset . 4)))) Style "stroustrup" already specified c-basic-offset 4. If we need to specify this setting a second time, why don't we need to specify the style's other settings a second time, too?
