On 11.08.2017 11:08, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> On 08/10/2017 01:30 PM, Markus Armbruster wrote: [...] >>> We get basic test coverage for the following commands: >> >> Cool! >> >>> >>> qom-list-types >>> query-acpi-ospm-status >>> query-balloon (expected to fail) >> >>> query-vm-generation-id (expected to fail) >> >>> Most tested commands are expected to succeed. The test does not check >>> the return value then. A few commands are expected to fail because >>> they need special arguments to succeed, and this test is too dumb to >>> supply them. >> >> Sounds like it would just be a matter of adding additional command line >> parameters to the qemu being invoked for testing those commands? > > In theory, setting up the state required for a query to succeed could be > too complex for this stupid test. > > In practice, query-balloon should need just "-device virtio-balloon", > and query-vm-generation-id should need just "-device vmgenid" and ACPI > (I think). Not all machines can do these devices. Let's what I can do > in v2.
FWIW: I think the balloon testing could also go into tests/virtio-balloon-test.c instead ... that test is only run on architectures where the device should be available. Thomas
