On 08/30/2017 06:33 AM, Juan Quintela wrote: > We were using -1 instead of the real size because the functions check > what is bigger, size in bytes or the size of the iov. Recent gcc's > barf at this. > > Signed-off-by: Juan Quintela <quint...@redhat.com> > > -- > > Remove comments about this feature. > Fix missing -1. > --- > include/qemu/iov.h | 6 ------ > tests/test-iov.c | 10 +++++----- > 2 files changed, 5 insertions(+), 11 deletions(-) > > diff --git a/include/qemu/iov.h b/include/qemu/iov.h > index bd9fd55b0a..72d4c559b4 100644 > --- a/include/qemu/iov.h > +++ b/include/qemu/iov.h > @@ -31,11 +31,6 @@ size_t iov_size(const struct iovec *iov, const unsigned > int iov_cnt); > * Number of bytes actually copied will be returned, which is > * min(bytes, iov_size(iov)-offset) > * `Offset' must point to the inside of iovec. > - * It is okay to use very large value for `bytes' since we're > - * limited by the size of the iovec anyway, provided that the > - * buffer pointed to by buf has enough space.
Is this part of the comment still okay? > One possible > - * such "large" value is -1 (sinice size_t is unsigned), Nice that we're losing the typo in the process :) > - * so specifying `-1' as `bytes' means 'up to the end of iovec'. I agree with dropping this though. As mentioned elsewhere, we had crossed mails between v1 reviews and v2 submission, so we'll probably need a v3 anyways. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
