On 08/30/2017 07:01 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> On 08/25/2017 05:59 AM, Marc-André Lureau wrote: >>> A step towards completeness. >>> >>> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> >>> Reviewed-by: Markus Armbruster <arm...@redhat.com> >>> --- >>> include/qapi/qmp/qdict.h | 4 +++- >>> target/i386/cpu.c | 4 ++-- >>> 2 files changed, 5 insertions(+), 3 deletions(-) >> >> Is it worth touching up scripts/coccinelle/qobject.cocci at the same time? > > Let's keep it up-to-date. I can do it when I apply. > >> I guess we don't care about a qlist_append_null() variant? > > Only if we have users.
Most (all?) of our qlist_ users tend to be heterogenous; we insert list members that have the same type. I don't see anyone wanting a list of all null objects any time soon; about the only reason to support it would be if we wanted a list of the StrOrNull alternate type, where some list elements can be null. But you're right that we don't have to add it now. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
