On 08/23/2017 09:47 AM, Fam Zheng wrote: > On Wed, 08/23 09:36, Eric Blake wrote: >> On 08/23/2017 08:42 AM, Fam Zheng wrote: >>> These two conditions corresponds to mirror job's source and target, >> >> s/corresponds to/correspond to a/ >> >> [can touch up on pull request] >> >>> which need to be allowed as they are part of the non-shared storage >>> migration workflow: failing to inactivate either will result in a >>> failure during migration completion. >>> >>> Signed-off-by: Fam Zheng <f...@redhat.com> >>> --- >>> block/block-backend.c | 21 ++++++++++++++++----- >>> include/sysemu/block-backend.h | 1 + >>> 2 files changed, 17 insertions(+), 5 deletions(-) >>> >>> >>> - return false; >>> + /* Inactivating means no more write to the image can be done, even if >>> it's >> >> s/write/writes/ >> >>> + * guest invisible change. For block job BBs that satisfy this, we can >>> just >> >> reads awkwardly. Maybe 'even if it's changes invisible to the guest'? >> But I can leave your wording if I don't get confirmation. > > Not sure I understand the grammar of "it's changes" but yours must be better. > Feel free to update it. Thanks,
If it's confusing, we can still do better. I settled on: no more writes to the image can be done, even if those writes would be changes invisible to the guest. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
