On Mon, 21 Aug 2017 15:32:23 +0200 Halil Pasic <pa...@linux.vnet.ibm.com> wrote:
> On 08/21/2017 03:16 PM, Cornelia Huck wrote: > > On Mon, 21 Aug 2017 13:41:53 +0200 > > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > > > >> On 08/21/2017 11:16 AM, Cornelia Huck wrote: > >>> If we do not provide zpci, pci reconfiguration via sclp is not available > >>> either. Don't indicate it in the sclp facilities and return an invalid > >>> command if the guest tries to issue pci configure/deconfigure. > >>> > >>> Reviewed-by: Thomas Huth <th...@redhat.com> > >>> Signed-off-by: Cornelia Huck <coh...@redhat.com> > >>> --- > >>> hw/s390x/sclp.c | 19 +++++++++++++++---- > >>> 1 file changed, 15 insertions(+), 4 deletions(-) > > > > (...) > > > >> LGTM > > > > Is that an Acked-by:? Or a Reviewed-by:? :) > > > > r-b If you write that out in future, I can simply copy'n'paste it :) > > (Not sure what Acked-by from a role other that affected > maintainer means.) I've always used it in the sense of "I don't know the gory details, and I haven't tried to find them out, but it generally looks sane to me".
