On Tue, Aug 08, 2017 at 04:05:56PM -0500, Eric Blake wrote: > On 08/08/2017 03:38 PM, Jens Freimann wrote: > > This implements a testcase for pxe-test using the vhost-user interface. > > Spawn a > > vhost-user-bridge process and connect it to the qemu process. > > > > To make the testcase work we need to apply a few patches before the actual > > testcase: > > - Patch 1 disables debug output of vhost-user-bridge > > - Patch 2 fixes passing a file descriptor to -netdev. This was broken > > since the > > mcast option was introduced. > > Is this a regression worthy of fixing in rc3? Or are we okay with this > entire series waiting for 2.11.
I'd say patches 2-4 at least are bugfixes. Is patch 5 worth including? I'm split on this, to me it does seem very important that we include a proper testcase for vhost-user, otherwise it's possible that downstreams ship a non-working version. I'll think about it over night. > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org >
