On Fri, Aug 04, 2017 at 06:26:41PM +0800, Mao Zhongyi wrote: > When the function no success value to transmit, it usually make the > function return void. It has turned out not to be a success, because > it means that the extra local_err variable and error_propagate() will > be needed. It leads to cumbersome code, therefore, transmit success/ > failure in the return value is worth. > > So fix the return type of blkconf_apply_backend_options(), > blkconf_geometry() and virtio_blk_data_plane_create() to avoid it. > > Cc: John Snow <js...@redhat.com> > Cc: Kevin Wolf <kw...@redhat.com> > Cc: Max Reitz <mre...@redhat.com> > Cc: Stefan Hajnoczi <stefa...@redhat.com> > > Signed-off-by: Mao Zhongyi <maozy.f...@cn.fujitsu.com> > --- > hw/block/block.c | 15 +++++++++------ > hw/block/dataplane/virtio-blk.c | 12 +++++++----- > hw/block/dataplane/virtio-blk.h | 2 +- > include/hw/block/block.h | 4 ++-- > 4 files changed, 19 insertions(+), 14 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
